Build and pull sail services on installation #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In laravel/sail#467 I made the
sail:install
command automatically build and pull the required services so that the firstsail up
can start serving immediately.However, when installing Laravel Sail via
laravel.build
, thesail:install
command is run inside a temporary container where it cannot run the docker commands 🤦♀️I have created laravel/sail#468 that prevents
sail:install
from attempting to run the docker commands when docker is not available.This PR adds that same functionality to
laravel.build
so that the firstsail up
starts serving immediately, no matter how you install Laravel Sail.